feat!: migrate clean-ghcr workflow to use GH token #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelol
approved these changes
Dec 11, 2023
|
Depends on #49 |
erikgb
force-pushed
the
migrate-gh-token
branch
from
9765356
to
ad320bb
Compare
erikgb
force-pushed
the
migrate-gh-token
branch
from
ad320bb
to
702d88d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since https://github.com/snok/container-retention-policy/releases/tag/v2.2.0 (snok/container-retention-policy#70) https://github.com/snok/container-retention-policy supports using GH token to authenticate. This allows us to avoid using PATs.
Using the GH token only works for a single image matching the repository that runs the action. This is also how we use this action right now, ref. https://github.com/search?q=org%3Astatnett%20clean-ghcr.yaml&type=code
BREAKING CHANGE: Calling workflows have to remove use of removed parameters