Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hierarchical time series #1

Open
4 of 5 tasks
GregorDeCillia opened this issue Jan 31, 2019 · 2 comments
Open
4 of 5 tasks

Add support for hierarchical time series #1

GregorDeCillia opened this issue Jan 31, 2019 · 2 comments
Assignees
@GregorDeCillia
Labels
enhancement New feature or request
Milestone
Q20

Comments

@GregorDeCillia
Copy link
Contributor

GregorDeCillia commented Jan 31, 2019 •
edited
Loading

As discussed with @alexkowa and @merangelik, it would be a good idea to add a class for hierarchical time series.

  • Add support for the class to contain several tramoseatsSingle and x13Single objects
  • Add a method addAggregate() to define weighted aggregates between the *Single objects
  • Implement a run() method that performs a direct and indirect adjustment
  • Implement diagnostic methods to compare the direct and indirect versions
  • plot() method

All this work should be done within the current polymorphic structure by introducing a new class persephoneSingle.

persephone
  ├─ persephoneSingle
  │    ├─ tramoseatsSingle
  │    └─ x13Single
  └─ hierarchicalTimeseries
@GregorDeCillia GregorDeCillia added the enhancement New feature or request label Jan 31, 2019
@GregorDeCillia
Copy link
Contributor Author

GregorDeCillia commented May 21, 2019 •
edited
Loading

A UML diagram of the planned class design (composite pattern)

persephone_UML_details

GregorDeCillia added a commit that referenced this issue May 21, 2019
@GregorDeCillia
introduce class persephoneSingle
85a82f5 
so far, this class just delegates methods
to the base class persephone.

See the UML diagram in #1 for details
@GregorDeCillia GregorDeCillia added this to the UseR! 2019 milestone May 23, 2019
@GregorDeCillia GregorDeCillia pinned this issue May 23, 2019
@GregorDeCillia GregorDeCillia self-assigned this May 23, 2019
GregorDeCillia added a commit that referenced this issue May 23, 2019
@GregorDeCillia
first version of hierarchical class
6d92e8a 
allow recursive calls to run() for all
components using a composite pattern

part of #1
@GregorDeCillia
Copy link
Contributor Author

About the missing TODO

  • Implement diagnostic methods to compare the direct and indirect versions

of this issue: We should check out https://github.com/djhurio/SA-indirect-quality and possibly contact the author about reusing some functionalities of that package.

@GregorDeCillia GregorDeCillia removed this from the UseR! 2019 milestone Sep 5, 2019
@GregorDeCillia GregorDeCillia added this to the Q20 milestone Jan 27, 2020
@merangelik merangelik unpinned this issue Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregorDeCillia GregorDeCillia

Labels
enhancement New feature or request
Projects
None yet
Milestone
Q20
Development

No branches or pull requests
1 participant
@GregorDeCillia