Open
Conversation
BREAKING: GetJavaScriptEnginePool signature in IExecutionState.cs changed as follows: - renamed to GetJavaScriptEngine - All parameters removed and replaced with a single Action<IJavaScriptEngine> parameter which is used to configure the engine. - removes the JSPool package from Statiq.Core.csproj. - bumps JavaScriptEngineSwitcher packages to latest versions. - removes all classes related to JavaScript Engine Pooling. - updates consuming code in the Statiq.Highlight extension.
…pt Engine. Under the previous Pooled model of JavaScript Engine provision, each call to the `HighlightCode.HighlightElement` function would retrieve a 'clean' JavaScript engine from the pool. Given that JavaScript Engines cannot be reset this change ensures that the previous behavior of consuming a fresh JavaScript Engine for every call to the `HighlightCode.HighlightElement` function is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsEngineSwitcherdeps to latest versions.BREAKING CHANGE:
GetJavaScriptEnginePoolinIExecutionContexthas been removed and replaced byGetJavaScriptEnginewhich returns a singleIJavaScriptEngineinstead of a pool.Changes
inIExecutionContexthas been removed and replaced byGetJavaScriptEnginewhich returns a singleIJavaScriptEngine`.IExecutionContexthave been updated.GetJavaScriptEnginemethod retains anAction<IJavaScriptEngine>parameter to enable engine configuration.HighlightCodeextension has been refactored to retain the behaviour that each call toHighlightCode.HighlightElementuses a clean JavaScript Engine.