-
Notifications
You must be signed in to change notification settings - Fork 55
chore: update template #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
manekinekko
commented
Mar 8, 2022
- update angular core and cli
- add SWA CLI dependencie
- add SWA CLI config
- update instructions
cbebf6f
to
136fc2a
Compare
|
||
> Note: This command will use the local configuration file `swa-cli.config.json`. | ||
|
||
### Run unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal preference to not include test, e2e, and lint in the Readme. That's easily found by checking npm run
and this kind of info tends to run out of date with the package.json over time. I'd only list install and swa commands. But not blocking.
"@angular/cli": "~13.2.5", | ||
"@angular/compiler-cli": "~13.2.5", | ||
"@angular/language-service": "~13.2.5", | ||
"@azure/static-web-apps-cli": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*
seems a bit generous :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM