Skip to content

chore: update template #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 24, 2022
Merged

Conversation

manekinekko
Copy link
Contributor

  • update angular core and cli
  • add SWA CLI dependencie
  • add SWA CLI config
  • update instructions


> Note: This command will use the local configuration file `swa-cli.config.json`.

### Run unit tests
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal preference to not include test, e2e, and lint in the Readme. That's easily found by checking npm run and this kind of info tends to run out of date with the package.json over time. I'd only list install and swa commands. But not blocking.

"@angular/cli": "~13.2.5",
"@angular/compiler-cli": "~13.2.5",
"@angular/language-service": "~13.2.5",
"@azure/static-web-apps-cli": "*",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* seems a bit generous :)

Copy link

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glaucia86 glaucia86 merged commit 20e51f0 into staticwebdev:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants