Skip to content

Liftingsupport #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chb/app/CHVersion.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
chbversion: str = "0.3.0-20250314"
chbversion: str = "0.3.0-20250318"
45 changes: 28 additions & 17 deletions chb/arm/opcodes/ARMStoreMultipleIncrementAfter.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@

if TYPE_CHECKING:
from chb.arm.ARMDictionary import ARMDictionary
from chb.invariants.VAssemblyVariable import VRegisterVariable
from chb.invariants.VAssemblyVariable import (
VRegisterVariable, VMemoryVariable)
from chb.invariants.XVariable import XVariable
from chb.invariants.XXpr import XXpr, XprConstant, XprVariable

Expand Down Expand Up @@ -417,28 +418,23 @@ def ast_prov(
if xdata.instruction_subsumes():
return self.ast_prov_ldmstmcopy(astree, iaddr, bytestring, xdata)

else:
xd = ARMStoreMultipleIncrementAfterXData(xdata)
if not xd.is_ok:
chklogger.logger.error(
"AST conversion of STM not yet supported at address %s",
iaddr)
"STM: Error value encountered at address %s", iaddr)
return ([], [])

regcount = len(xdata.reachingdefs) - 1
annotations: List[str] = [iaddr, "STM"]

'''
baselhs = xdata.vars[0]
memlhss = xdata.vars[1:]
baserhs = xdata.xprs[0]
baseresult = xdata.xprs[1]
baseresultr = xdata.xprs[2]
regrhss = xdata.xprs[3:3 + regcount]
#rregrhss = xdata.xprs[3 + regcount:3 + (2 * regcount)]
baserdef = xdata.reachingdefs[0]
regrdefs = xdata.reachingdefs[1:]
baseuses = xdata.defuses[0]
memuses = xdata.defuses[1:]
baseuseshigh = xdata.defuseshigh[0]
memuseshigh = xdata.defuseshigh[1:]

annotations: List[str] = [iaddr, "STMIA"]
'''

# low-level assignments

Expand All @@ -448,6 +444,12 @@ def ast_prov(
(baselval, _, _) = self.opargs[0].ast_lvalue(astree)
(baserval, _, _) = self.opargs[0].ast_rvalue(astree)

memlhss = xd.memlhss
regrhss = xd.rhss
regrdefs = xdata.reachingdefs[1:]
memuses = xdata.defuses[1:]
memuseshigh = xdata.defuseshigh[1:]

regsop = self.opargs[1]
registers = regsop.registers
base_offset = 0
Expand All @@ -469,10 +471,11 @@ def ast_prov(

# high-level assignments

lhs = memlhss[i]
rhs = regrhss[i]
hl_lhs = XU.xvariable_to_ast_lval(lhs, xdata, iaddr, astree)
hl_rhs = XU.xxpr_to_ast_def_expr(rhs, xdata, iaddr, astree)
memlhs = memlhss[i]
regrhs = regrhss[i]

hl_lhs = XU.xvariable_to_ast_lval(memlhs, xdata, iaddr, astree)
hl_rhs = XU.xxpr_to_ast_def_expr(regrhs, xdata, iaddr, astree)
hl_assign = astree.mk_assign(
hl_lhs,
hl_rhs,
Expand All @@ -491,6 +494,13 @@ def ast_prov(

base_offset += 4

if (
(memlhs.is_memory_variable
and cast("VMemoryVariable",
memlhs.denotation).base.is_basevar)):
astree.add_expose_instruction(hl_assign.instrid)

'''
if self.writeback:

# low-level base assignment
Expand Down Expand Up @@ -528,5 +538,6 @@ def ast_prov(
astree.add_expr_reachingdefs(ll_base_rhs, [baserdef])
astree.add_lval_defuses(hl_base_lhs, baseuses)
astree.add_lval_defuses_high(hl_base_lhs, baseuseshigh)
'''

return (hl_instrs, ll_instrs)
4 changes: 4 additions & 0 deletions chb/invariants/VMemoryOffset.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@ def __init__(
def is_no_offset(self) -> bool:
return True

@property
def is_constant_value_offset(self) -> bool:
return True

def offsetvalue(self) -> int:
return 0

Expand Down