Skip to content

Backport petrinets.org code #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Backport petrinets.org code #4

wants to merge 4 commits into from

Conversation

antonleviathan
Copy link

  • Remove backticks
  • Add boundary drawing code
  • Break out some functions and remove repetition in petrinet.js and app.js

@antonleviathan antonleviathan requested a review from epost August 10, 2018 11:54
@antonleviathan
Copy link
Author

There is still cleaning up to be done but just wanted to get a PR up.

epost
epost reviewed Aug 10, 2018
View reviewed changes
Copy link
Member

@epost epost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. it seems like drawing and 'model' code are intermixed; which would be good to try and separate at some point

  2. there seem to be <10 usages of underscore, so i'd say get rid of it

  3. i see some comments that shouldn't have to exist in favour of nice records

  4. _pnet3 and such suffixes should be vapourised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epost epost epost left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonleviathan @epost