Remove unused batch_shape variable in _get_states_from_cache#906
Open
Chessing234 wants to merge 1 commit intostate-spaces:mainfrom
Open
Remove unused batch_shape variable in _get_states_from_cache#906Chessing234 wants to merge 1 commit intostate-spaces:mainfrom
Chessing234 wants to merge 1 commit intostate-spaces:mainfrom
Conversation
The `batch_shape` variable was assigned but never referenced in `Mamba._get_states_from_cache` and `Mamba2._get_states_from_cache`, making it dead code. This removes it from both modules. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batch_shapevariable fromMamba._get_states_from_cacheinmamba_simple.pyandMamba2._get_states_from_cacheinmamba2.py(batch_size,)but never referenced, making it dead codeDetails
Both
_get_states_from_cachemethods contained:This line has no effect since
batch_shapeis not used anywhere in the function body. Removing it improves code clarity.Test plan