-
Notifications
You must be signed in to change notification settings - Fork 8
Fixed many typos at README.md #44
base: master
Are you sure you want to change the base?
Conversation
rabits
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor bugs
|
|
||
| It's integrated with the current Blender render engine and allows user to send the | ||
| same configuration to the Manager to use the cloud resources for rendering. | ||
| the same configuration to the Manager to use the cloud resources for rendering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need in additional the
| render - and the Manager decides how many samples it will give to an Agent. The Manager | ||
| tries to keep the ratio loading/rendering relatively lower, but less than 30 mins per | ||
| Agent task. By default it's 100 samples per Agent task. | ||
| Agent task. By default, it's 100 samples per Agent task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need comma here?
| When Addon wants to talk with Manager - it provides credentials in the HTTP request | ||
| header, Manager compares those creds with the stored ones and if they are ok - allow | ||
| the request and respond. | ||
| the request and response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Means respond to the request, not "allows both request and response".
| Required to encrypt the message transport - so no one but client and server can read | ||
| those messages during transmission. That means any communication or transfer between | ||
| Addon & Manager or Manager and Agent is completely encrypted. | ||
| Addon & Manager or Manager and Agent are completely encrypted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Communication - is, right? Like in the line 49
| ### Addon configuration | ||
|
|
||
| Addon is using provider tools for its configuration. So check that your provider tool is available | ||
| The addon is using provider tools for its configuration. So check that your provider tool is available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addon - capitalized.
| script that downloads the Manager scripts from the bucket and runs them. After that Manager generates | ||
| CA and server SSL certificates and shares the CA certificate with Addon. Addon tries to connect the | ||
| Manager using ssl connection and the credentials from configuration (or generated ones). | ||
| A manager using an SSL connection and the credentials from configuration (or generated ones). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manager - capitalized
| The addon is using provider tools for its configuration. So check that your provider tool is available | ||
| in your PATH and working correctly: you should be able to create an instance and bucket in the | ||
| default project using the provider tool. | ||
| default project using the provided tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's provider, cloud provider.
| * Command `gsutil rm -r gs://test-bucket-jsfkhbqfhbqw` should clean and delete the test bucket | ||
|
|
||
| Of course it's just an example - but in general case those commands should work for you. | ||
| Of course, it's just an example - but in general case those commands should work for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure comma is needed here.
|
|
||
| This action actually uses bucket creation, bucket files upload, instance creation, autostarting | ||
| script that downloads the Manager scripts from bucket and runns them. After that Manager generates | ||
| This action actually uses bucket creation, bucket files upload, instance creation, an autostarting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an - probably "and"? So without comma.
No description provided.