[6.x] Update ip_address protector to use request()->ips()#14063
Open
gavynd6 wants to merge 1 commit intostatamic:6.xfrom
Open
[6.x] Update ip_address protector to use request()->ips()#14063gavynd6 wants to merge 1 commit intostatamic:6.xfrom
gavynd6 wants to merge 1 commit intostatamic:6.xfrom
Conversation
gavynd6
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IP Address protector does not work when hosted behind a load balancer, as it uses
request()->ip()rather thanrequest->ips(), so does not detect theX-Forwarded-Forheader.This PR looks at all the IP addresses available in the request.