[5.x] Fix CSRF token on pages excluded from static caching#14056
Merged
jasonvarga merged 2 commits into5.xfrom Feb 25, 2026
Merged
[5.x] Fix CSRF token on pages excluded from static caching#14056jasonvarga merged 2 commits into5.xfrom
jasonvarga merged 2 commits into5.xfrom
Conversation
duncanmcclean
commented
Feb 24, 2026
| return false; | ||
| } | ||
|
|
||
| if ($this->cacher instanceof AbstractCacher && $this->cacher->isExcluded($this->cacher->getUrl($request))) { |
Member
Author
There was a problem hiding this comment.
I'm checking the AbstractCacher here because the isExcluded method doesn't exist on the Cacher interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where excluded pages received
STATAMIC_CSRF_TOKENinstead of the real token, causing 419 errors when submitting forms.The URL exclusion check was happening in
cachePage()after the replacers had already modified the response (eg. the real token being replaced w/ the placeholder). This PR moves the check intoshouldBeCached()so excluded pages skip the replacement logic entirely.Fixes #14053