Open
Conversation
…would cause issues with Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR Does
Adds keyboard shortcuts to the bulk actions floating toolbar (Esc to deselect, Delete/Backspace for delete, and one letter per action from the localised label) so power users can run actions without leaving the keyboard.
Light Mode
Dark Mode
What's new
U, "Depubliceren" →Din Dutch).PwhenUis taken for Unpublish). Letters are assigned in order through the label so shortcuts stay predictable and readable in every language.Escclears the selection and closes the toolbar.DeleteorBackspacetrigger delete. The delete action always shows the backspace icon in the toolbar (no letter), so it's consistent and doesn't steal a letter from other actions.Implementation
BulkActionsFloatingToolbar.vueholds all shortcut logic and UI, so the listing stays clean and the toolbar is easy to maintain.Files changed
resources/js/components/ui/Listing/BulkActionsFloatingToolbar.vue— Toolbar with shortcut assignment, key handling, and badges.BulkActions.vue— Uses the new floating toolbar component and passes actions, visibility, selections, and clear callback.resources/svg/icons/backspace.svg— delete shortcut icon. FYI I did try delete icons from the Flex Line library but it didn't quite site right, so I ended up adding a custom one.How to Reproduce