[6.x] Prevent the tree structure from flashing when disclosures open #13462
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nodes when toggling them open, less it looks glitchy and feels unresponsive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #13457.
The issue was caused by starting transitions firing when disclosures opened, since the tree nodes were "appearing", causing an opacity transition.
This is a simple fix that adds a modifier class to the
.page-treeafter it's been interacted with, so we can effectively disable the initial transitions after anything has been clicked.I would have gone with an HTML class approach for transitions here, but I couldn't easily modify the inner HTML—so this is simpler.