Skip to content

Conversation

@duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Nov 28, 2025

This pull request fixes an issue where options might get cut off in a Combobox dropdown. It also adds a scrollbar to improve usability when there's lots of options:

CleanShot.2025-11-28.at.11.50.41.mp4

Unfortunately, because we need to virtualize the options to help with performance, it means that only the visible options actually exist in the DOM.

This means we can't rely on the browser's built-in scrollbar, we have to build our own. It's a little bit of a pain, but 🤷‍♂️

Closes #13205

@duncanmcclean duncanmcclean changed the title [6.x] Prevent options being cut off in Combobox dropdown [6.x] Combobox: Prevent options being cut off & add scrollbar Nov 28, 2025
@jackmcdade
Copy link
Member

jackmcdade commented Dec 1, 2025

Was the Reka Scrollbar not an option here? Otherwise, looks and works great on my end!

@duncanmcclean
Copy link
Member Author

duncanmcclean commented Dec 3, 2025

Was the Reka Scrollbar not an option here? Otherwise, looks and works great on my end!

I looked into Reka's ScrollArea component, but unfortunately, it doesn't work alongside virtualisation because it relies on the browser's native scroll stuff under the hood.

With virtualization, only a handful of options actually exist in the DOM at once.

@jasonvarga jasonvarga merged commit 6bf414c into master Dec 5, 2025
11 checks passed
@jasonvarga jasonvarga deleted the combobox-being-cut-off branch December 5, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[6.x] Long Select/Combobox lists have options that are unobtainable (and lacking expected UX cues)

4 participants