[5.x] Static warm: recheck whether page is cached for queued requests #11273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
approved these changes
Dec 17, 2024
|
Weird test failures. I thought it was one of those random failures and rerunning would solve it. 🤔 |
|
I was thinking the same thing. Weird. FWIW I ran the tests locally and they all succeeded. |
|
I'll check them out. The PR looks good though. |
|
It's not you. 😄 #11275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using both the
--queueand--uncachedparameters:By the time a queued job gets executed, the page was possibly already cached in the meantime. The dedicated
StaticWarmUncachedJobchecks again if the page is cached, and if so, it won't send the request.