Skip to content

add ssr support #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021
Merged

add ssr support #105

merged 1 commit into from
Feb 3, 2021

Conversation

Sitronik
Copy link
Collaborator

@Sitronik Sitronik commented Feb 3, 2021

When I import vue-slick I get this error in ssr:

ReferenceError: window is not defined
    at /Users/denis/Documents/projects/project/node_modules/vue-slick/dist/slickCarousel.cjs.js:245:17
    at /Users/denis/Documents/projects/project/node_modules/vue-slick/dist/slickCarousel.cjs.js:241:26
    at /Users/denis/Documents/projects/project/node_modules/vue-slick/dist/slickCarousel.cjs.js:244:2
    at createCommonjsModule (/Users/denis/Documents/projects/project/node_modules/vue-slick/dist/slickCarousel.cjs.js:235:35)
    at Object.<anonymous> (/Users/denis/Documents/projects/project/node_modules/vue-slick/dist/slickCarousel.cjs.js:238:13)
    at Module._compile (internal/modules/cjs/loader.js:759:30)
    at Module._compile (/Users/denis/Documents/projects/project/node_modules/pirates/lib/index.js:99:24)
    at Module._extensions..js (internal/modules/cjs/loader.js:770:10)
    at Object.newLoader [as .js] (/Users/denis/Documents/projects/project/node_modules/pirates/lib/index.js:104:7)
    at Module.load (internal/modules/cjs/loader.js:628:32)
    at Function.Module._load (internal/modules/cjs/loader.js:555:12)
    at Module.require (internal/modules/cjs/loader.js:666:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at r (/Users/denis/Documents/projects/project/node_modules/vue-server-renderer/build.dev.js:9315:16)
    at eval (webpack-internal:///vue-slick:1:18)
    at Object.vue-slick (main.js:1325:1)

And in client:
500 | Internal Server Error

Fixed it all, please merge

@staskjs staskjs merged commit ab80fd5 into staskjs:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants