Offer details API #1
Conversation
| }, | ||
| (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {description: "Optional region filter using ISO-3166-1 alpha-2 country code (e.g., 'US', 'EU', 'JP')"} | ||
| ]; | ||
| optional string language = 4 [ |
There was a problem hiding this comment.
we may need to use the 4 letter code here i think to differentiate between regional languages like es-ES vs es-MX
| ]; | ||
| optional string background_style = 4 [(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {description: "Optional background styling for metadata section"}]; | ||
| } | ||
| OfferMetadata metadata = 3 [ |
There was a problem hiding this comment.
as we discussed in our last 1:1 it looks like we also need to add in an array of some sort to represent the list of sections in the metadata and their contents. Note that in some cases text is uppercased vs not so we need a way to configure that as well
| } | ||
| }; | ||
| LocalizableText text = 1 [(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {description: "Header text content"}]; | ||
| optional uint32 relative_width = 2 [ |
There was a problem hiding this comment.
are we going to validate that the widths of all the headers add to 100? if not how do you envision we handle that?
There was a problem hiding this comment.
also if not provided, should we assume the space is evenly distributed then?
| ]; | ||
| } | ||
|
|
||
| message Tab { |
There was a problem hiding this comment.
this needs to also have a tab title right? (LocalizableText)
| (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {description: "Optional URL to icon image for the cell"} | ||
| ]; | ||
| optional string background_style = 4 [(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {description: "Optional CSS-style background styling for the cell"}]; | ||
| optional string text_style = 5 [(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {description: "Optional CSS-style text styling for the cell"}]; |
There was a problem hiding this comment.
what is an example format of how you see this being used? there are different text properties that could be configured like text-transform, color, etc. would those be combined into one string here or should this be for a more specific text styling?
No description provided.