Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set default studio image #887

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

WithoutPants
Copy link
Collaborator

When creating studio, it currently sets the default image if one is not provided. This causes incorrect behaviour for the Is Missing Image filter. Changed so that the default image is no longer set if it is not provided. Placeholder image is used for studios without images when viewing them, but they will correctly be filtered for is missing image.

Resolves #866

@WithoutPants WithoutPants added the bug Something isn't working label Oct 24, 2020
@WithoutPants WithoutPants added this to the Version 0.4.0 milestone Oct 24, 2020
@bnkai
Copy link
Collaborator

bnkai commented Oct 24, 2020

Looks/Works ok.
For existing studios should the user manually edit-> clear the existing default images?

DELETE FROM studios_image WHERE length(image) = 405 ;

seems to work for me. ( I am not sure how probable it is to have another studio image with that size)

@WithoutPants WithoutPants merged commit c75b5c2 into stashapp:develop Oct 26, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
@WithoutPants WithoutPants deleted the no-studio-image branch February 4, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Studio: Is Missing Image filter doesn't work
2 participants