Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images section #813

Merged
merged 40 commits into from
Oct 12, 2020
Merged

Images section #813

merged 40 commits into from
Oct 12, 2020

Conversation

WithoutPants
Copy link
Collaborator

Part of #24.

Refactors the scanning logic so that it walks the directory structure instead of globbing the results. Hoping that this will incidentally increase scanning performance further.

Adds customisable file extensions for video, images and gallery files.

Changes the stashes format to support excluding video or image/gallery scanning per stash.

image

Scanning now reads in individual image files.

Adds a new top-level Images section:

image

Wall view uses the flexbin/lightbox from the gallery viewer:

image

The image page is pretty much a direct copy of the scene page:

image

Includes export support, but does not include import support. Import support is waiting on #812.

Schema changes have been made for the new gallery attributes, but no other support is currently implemented.

Other things to do:

  • adding images to galleries
  • manual creation of galleries
  • auto-creation of folder galleries (when selected in the settings)
  • scan gallery zip contents to create individual images
  • add image tabs to performers/studios

Some of the above can probably be pushed into a separate PR.

I didn't intend to have images have their own page, but for it was quicker and easier to start with the scene page as a base.

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Sep 17, 2020
@WithoutPants WithoutPants added this to the Version 0.4.0 milestone Sep 17, 2020
@bnkai
Copy link
Collaborator

bnkai commented Sep 17, 2020

Just from a quick test
Switching from glob star to filepath walk adds a regression for the scanning task.
While the old glob scan traversed through softlinked directories filepath walk by design doesn't.
So users with softlinks in their media paths won't get the same results as before
Related also to issue #706

@WithoutPants
Copy link
Collaborator Author

This has turned into a pretty huge change. I'm going to take a break on the main development, to allow some time for testing. It now has manual gallery creation, auto creation/association for folder galleries, and a very clunky add/remove images for galleries. The galleries now have their own page with all of the fields. It's very untested at the moment.

I'm aware of the issue of adding/removing images in galleries not refreshing automatically, but otherwise most of the functionality should be present.

@cloudstrife11
Copy link

When will this come, Or do u guys need help testing, I have many many images for testing.

@WithoutPants
Copy link
Collaborator Author

I still have to do the import code, and I'd like to clean up the gallery image add/remove UI, but yes, it probably needs some testing.

@bnkai
Copy link
Collaborator

bnkai commented Oct 4, 2020

Since transfer.sh crapped out again and there was some interest from the discord channel i made some cross-compilations for anyone that wants to give it a try ( with caution ofc :-) )
md5s

f7ac59c6e3edc2be052609a5c589689b  stash-linux
55d43450f9e9ce51bd49be1b3378f1bb  stash-linux-arm32v7
e6505711e566fdf178fa4a64ca8b60a0  stash-linux-arm64v8
0e71209bbc861bcb2f26b0b83615a3ae  stash-osx
c706f4dbad978891ce969cebfe3ebf9a  stash-pi
3669e7612f5efdcf4041fb6430e25da0  stash-win.exe

download link
https://easyupload.io/m/r7p0uc

@bnkai
Copy link
Collaborator

bnkai commented Oct 6, 2020

Updated builds
md5s

39ed0b3a3d9f24372c7cf8bbcde601e8  stash-linux
cd62219392a9926a7063c9e92313a8f5  stash-linux-arm32v7
094e65ad1f83967197f4b07814bc688d  stash-linux-arm64v8
013842d08a5ddbcf0f9212abc1a2b920  stash-osx
3376518c352781744e8587da0e322fd1  stash-pi
1fd80870c82d9e46ac4f5ec18a0e6c65  stash-win.exe

https://easyupload.io/m/1jxj84

will try to test over the weekend

@bnkai
Copy link
Collaborator

bnkai commented Oct 7, 2020

updated
the ui formatting that errored travis shouldn't make much difference
md5s

589135cc1807b904838d626a4f74a016  stash-linux
c9b231e092e5536101a470bca990e74c  stash-linux-arm32v7
538784094a96a8355e6177e8ee01c1fc  stash-linux-arm64v8
c0174abae820ce7926ec5801db18a161  stash-osx
27c3039e1372dbcdbe56f4fd96e2a823  stash-pi
cb75e44c51a81a81ed12a1fa4623aa16  stash-win.exe

https://easyupload.io/m/ldikq1

@bnkai
Copy link
Collaborator

bnkai commented Oct 8, 2020

updated

2746bddc5ac6c773675eced129eeb025  stash-linux
4fadc5b321194cd8e1a6c3eb8bbf3382  stash-linux-arm32v7
bc6243a97af4ff7f320c2035cbc57ccf  stash-linux-arm64v8
5a245ccddcab92ba6f4257d0bffea876  stash-osx
dad3ddce5c304aaa38c227150eb2a7bd  stash-pi
a313073f21527edaab874aecd499270a  stash-win.exe

https://easyupload.io/m/zevbv4

@WithoutPants WithoutPants merged commit aca2c7c into stashapp:develop Oct 12, 2020
@WithoutPants WithoutPants linked an issue Nov 3, 2020 that may be closed by this pull request
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Add new configuration options
* Refactor scan/clean
* Schema changes
* Add details to galleries
* Remove redundant code
* Refine thumbnail generation
* Gallery overhaul
* Don't allow modifying zip gallery images
* Show gallery card overlays
* Hide zoom slider when not in grid mode
@WithoutPants WithoutPants deleted the images branch February 4, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make scanned filename extensions configurable
3 participants