Preview generation fallback #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeSmithStarkers
force-pushed
the
feature/preview_fallback
branch
from
2d2b62c
to
bf30697
Compare
JoeSmithStarkers
force-pushed
the
feature/preview_fallback
branch
2 times, most recently
from
1a40385
to
85cc9e7
Compare
bnkai
reviewed
Aug 13, 2020
|
Seems to work ok. EDIT. Added to milestone for v0.3 as whis would save as a lot of user help requests. |
When a preview generation fails (often for wmv/avi files), the new code tries with less stricted (no xerror) and more time consuming options (slow+fast seek). Fix a minor issue when stash downloads ffmpeg/ffprobe, but doesn't re-detect their paths.
JoeSmithStarkers
force-pushed
the
feature/preview_fallback
branch
from
85cc9e7
to
9caa2e4
Compare
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
* Added preview generation fallback feature. When a preview generation fails (often for wmv/avi files), the new code tries with less stricted (no xerror) and more time consuming options (slow+fast seek). Fix a minor issue when stash downloads ffmpeg/ffprobe, but doesn't re-detect their paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a preview generation fails (often for wmv/avi files), the new code tries with less stricted (no xerror) and more time consuming options (slow+fast seek). Fixes #635
Fix a minor issue when stash downloads ffmpeg/ffprobe, but doesn't re-detect paths.
Added comment about restoring a backup with a move operation.
Added .DS_Store to ignore list (mac osx annoying file)
Added pkg/pkg to ignore list (can't seem to configure goland to use the vendor dir)