Skip to content

feat: add per-alias autotag toggle + general api/app support for per-alias autotag#6694

Open
notsafeforgit wants to merge 8 commits intostashapp:developfrom
notsafeforgit:feat/autotag-aliases
Open

feat: add per-alias autotag toggle + general api/app support for per-alias autotag#6694
notsafeforgit wants to merge 8 commits intostashapp:developfrom
notsafeforgit:feat/autotag-aliases

Conversation

@notsafeforgit
Copy link
Contributor

@notsafeforgit notsafeforgit commented Mar 18, 2026

Add DB support and graphQL API support to track alias matching for a performer being on or off on a per-alias basis. By default, new aliases (especially from scrapers) are set to be ignored for auto-tagging. The UI toggle has been updated to reflect an 'Auto tag' boolean checkbox that allows users to opt-in specific aliases.

Attached is a screenshot of the new alias list UI with autotag toggles:

New performer edit page with alias toggles

@notsafeforgit notsafeforgit force-pushed the feat/autotag-aliases branch 8 times, most recently from a00cd5b to 1a68260 Compare March 18, 2026 02:51
Add DB support and graphQL API support to track alias matching being on or off per alias.
By default, new aliases (especially from scrapers) are set to be ignored for auto-tagging.
The UI toggle has been updated to reflect an 'Auto tag' boolean checkbox that allows users to opt-in specific aliases.
@notsafeforgit notsafeforgit force-pushed the feat/autotag-aliases branch 2 times, most recently from f7f5000 to d0c29d6 Compare March 18, 2026 05:26
@notsafeforgit notsafeforgit force-pushed the feat/autotag-aliases branch 6 times, most recently from 206ec11 to 83c44e3 Compare March 18, 2026 07:37
func toPerformerAliases(aliases []string) []models.PerformerAlias {
var res []models.PerformerAlias
for _, a := range aliases {
res = append(res, models.PerformerAlias{Alias: a, IgnoreAutoTag: true})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All current performers don't support autotagging aliases, so backups should be imported with autotag ignored for aliases set to true.

@notsafeforgit notsafeforgit force-pushed the feat/autotag-aliases branch 5 times, most recently from faae311 to f3057d3 Compare March 18, 2026 08:23
This fixes a bug where clicking Save in the performer edit panel did nothing. The yup schema requires the 'aliases' field to be present for casting, but it was being destructured out before being passed to `schema.cast()`, causing a validation crash inside Formik's onSubmit handler that silently aborted the save action.
…p panic

Modified NormalizeAliases to return an initialized empty slice instead of nil when aliases are empty. This ensures the aliases relationship is marked as 'loaded', preventing a panic in ValidateCreate. Added a corresponding unit test to verify creation with empty or filtered aliases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant