Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrape dialog #644

Merged
merged 21 commits into from
Jul 2, 2020
Merged

Scrape dialog #644

merged 21 commits into from
Jul 2, 2020

Conversation

WithoutPants
Copy link
Collaborator

@WithoutPants WithoutPants commented Jun 30, 2020

Adds a dialog when scraping scenes and performers that shows the existing and scraped values and allows choosing between them.

Example scene dialog:

image

Unlike the above image, in general any field that doesn't have scraped values is not shown in the dialog.

Example performer dialog:

image

This dialog is not shown in the new performers screen - details are piped directly to the fields.

A future iteration on this is to present new tags/performers/studios and allow adding them from this dialog.

Resolves #551
Fixes #646

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Jun 30, 2020
@WithoutPants WithoutPants added this to the Version 0.3.0 milestone Jun 30, 2020
@peolic
Copy link
Contributor

peolic commented Jun 30, 2020

@WithoutPants
Looks awesome!
I believe I have a bug report:
When you click to apply (I tried Performer - Scene seems to work well),
all the fields that you don't select from the scrape data, even ones that don't show up, get emptied (except maybe the image).
If you click Save, it then saves and displays correct data.

@bnkai
Copy link
Collaborator

bnkai commented Jun 30, 2020

Can confirm the above bug for the performer edit page.
For the scenes it doesnt seem to detect performers/tags even though they are scraped correctly, their field is empty and they exist in the DB ( i couldn't test movies because of lack of samples).

@WithoutPants
Copy link
Collaborator Author

Fixes #646

@WithoutPants WithoutPants linked an issue Jul 1, 2020 that may be closed by this pull request
@WithoutPants
Copy link
Collaborator Author

Thanks for testing this.

Made a few changes:

  • fixed population of performer fields after applying
  • scraping dialog now shows existing as the current values, rather than the original values. This means that if you edit the fields before scraping, the dialog will now show those new values, rather than the original values.
  • performers/tags are now displayed correctly
  • scene URL scrape button is now inline with the URL field, to be consistent with the performer edit page

Ready for retesting.

@peolic
Copy link
Contributor

peolic commented Jul 1, 2020

Retested, looks good!

@peolic
Copy link
Contributor

peolic commented Jul 1, 2020

Noticed one more thing:
Not sure if you want to do this as part of this PR or a separate one,
but the tags show up even if they are the same. Maybe only when more than one tag is matched.
Performers seem to work.

image

@WithoutPants
Copy link
Collaborator Author

Should be fixed. Wasn't detecting ids in different order.

@peolic
Copy link
Contributor

peolic commented Jul 1, 2020

@WithoutPants Yes, that fixed it.

@WithoutPants WithoutPants merged commit f1c544a into stashapp:develop Jul 2, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Fix performer page button spacing
* Improve scene URL scrape button styling
@WithoutPants WithoutPants deleted the scrape-dialog branch February 4, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] New Performer UI Buttons Spacing Isn't Consistent [Feature] Allow Scraper To Overwrite Data
3 participants