Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent studios #595

Merged
merged 20 commits into from
Jun 15, 2020
Merged

Parent studios #595

merged 20 commits into from
Jun 15, 2020

Conversation

WithoutPants
Copy link
Collaborator

@WithoutPants WithoutPants commented Jun 5, 2020

Continuation of #462 (thanks @Anon247 )

Resolves #115
Closes #410

Adds Parent Studio field to the create/edit studio page:

image

Changes the right panel of the studio page to be tabbed, showing Scenes (default view) and Child Studios.

image

On the Studios page, the studio cards show the parent studio (with a link to the studio page), and the number of child studios (with a link to the associated query):

image
image

Adds filter to studios for include/exclude parent studios.

Validation in the backend ensures that you cannot have a cyclic structure of studios (ie Studio A <- Studio B <- Studio A).

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Jun 5, 2020
@WithoutPants WithoutPants added this to the Version 0.3.0 milestone Jun 5, 2020
@bnkai
Copy link
Collaborator

bnkai commented Jun 7, 2020

From a quick test
Parent studios can't be unset.

Edit Studio
Set Parent
Save
Edit same studio
Unset Parent
Save
-> Parent studio is not unset

@Anon247
Copy link
Contributor

Anon247 commented Jun 7, 2020

Nice work @WithoutPants - apologies for going AWOL, work really picked up, and I wasn't able to dedicate any time to this PR.

@bnkai
Copy link
Collaborator

bnkai commented Jun 10, 2020

It seems to work fine now.

@WithoutPants WithoutPants merged commit 96e6e16 into stashapp:develop Jun 15, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Refactor getMultiCriterionClause
Co-authored-by: Anon247 <61889302+Anon247@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Producer and Studio [Feature] Parent studios
3 participants