freeones scraper tweaks #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I just didn't like the fact that MustCompile panics if something is wrong. In the specific cases that can only happen during development ( changing the regex ) or during a pkg version upgrade if the package is bugged. |
|
IMO yes. I don't think changing these are necessary. |
WithoutPants
approved these changes
May 4, 2020
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all regexp.MustCompile and logger.Fatal calls to make the scraper more predictable/consistent.
If a field is not valid skip it ( leave as nil) and continue to the next instead of exiting.
Add a default
3045 sec timeout to http requests ( no images are fetched so it should be safe, might need some more tweaking)