Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address resize loop #5004

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Conversation

cj12312021
Copy link
Collaborator

@cj12312021 cj12312021 commented Jun 21, 2024

This pull request updates the card resize code to only adjust the size when the container width changes by a significant enough margin. In this case, that margin is 15 pixels, which is the amount of horizontal space I see that the default scrollbar occupies. This value can increased if necessary.

@cj12312021
Copy link
Collaborator Author

cj12312021 commented Jun 22, 2024

I browsed around to all the sites and tools I was aware of, which dynamically sized the content based on container size, and noticed they all were either unaware of the issue or opted not to solve it. Said sites and tools are all the sites under the gamma umbrella (Adulttime, Evil Angel, Dfxtra, etc.) and the Mosicac plugin we use for the image wall view. Gamma sites won’t see this issue very easily because their footer or sidebar often ensures overflow is always after on their pages. I mention this because the solution comes at the cost of sensitivity and responsiveness. The margin I specified here is small enough to not be much of a hindrance. But I wanted to ensure the tradeoffs made here are clear.

@WithoutPants WithoutPants added the bug Something isn't working label Jun 24, 2024
@WithoutPants WithoutPants added this to the Version 0.27.0 milestone Jun 24, 2024
The existing value of 15 didn't fix the issue on Windows 10.
@WithoutPants
Copy link
Collaborator

I increased the sensitivity threshold to 20. The existing value didn't address the original issue on my Windows 10 system. Apparently the default scrollbar width is around 17 pixels on Windows.

@WithoutPants WithoutPants merged commit d986a9e into stashapp:develop Jun 24, 2024
2 checks passed
WithoutPants pushed a commit to WithoutPants/stash that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants