Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default view filters #4962

Merged
merged 10 commits into from
Jun 18, 2024
Merged

Conversation

WithoutPants
Copy link
Collaborator

@WithoutPants WithoutPants commented Jun 12, 2024

Supercedes #4036
Resolves #2404
Resolves #4010
Resolves #3079
Resolves #4137
Resolves #4754

Adapts @yoshnopa's work from #4036. Deprecates the default filter functions from the graphql interface. Instead, all default filter settings are stored in the UI settings. Each view in the UI has its own default filter that can be set.

The default filter is used when the view is loaded without any parameters.

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Jun 12, 2024
@WithoutPants WithoutPants added this to the Version 0.27.0 milestone Jun 12, 2024
Setting it to map[string]map[string]interface{} meant that when setting the partial, it wasn't able to convert to map[string]interface{} and caused a full overwrite of the default filters if saved after the migration.
@WithoutPants WithoutPants merged commit f9a624b into stashapp:develop Jun 18, 2024
2 checks passed
@yoshnopa
Copy link
Contributor

Great, just tested it!
However, I have an issue left:
I added the possibility to have the default filter/view applied on links as well. This does not seem to apply to your commit.
That one I still find to be the source of quite some inconsistency. For example, I'd assume that if I click on the gallery symbol of a tag in the front page that it will at the very least use my default view options (basically be the same as if I visited galleries regularly, just with the tag filter as an addition).
Or is there a reason that was phased out?

@WithoutPants
Copy link
Collaborator Author

I left it out to reduce the scope. I don't have immediate plans to implement it, but no injection to its inclusion.

Probably needs to be discussed in a separate feature request, but my preference would be that the tag links don't include a sort parameter and that the URL resolution code uses the default filter to determine the sort and view if these aren't provided.

@Croxi1
Copy link

Croxi1 commented Jul 8, 2024

Great work!

I am eternally grateful for everything you are doing!

Any chances of a timeline of version 0.27.0? Changing default scene number on a Performer page is a critical update for me which I cannot wait for.

Again, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment