Fix hwCanFullHWTranscode not detecting no filter errors #4934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A discord user experienced an error where full hardware transcoding didnt work without a filter (which wasn't tested, we always used a scale filter before).
This patch passes the requested resolution from the current transcode down to the tester, such that we test it with a filter if it needs one, or without a filter if it doesnt.
Note that the specific issue was:
Which usually indicates a driver/ffmpeg incompatibility, but nevertheless we shouldn't error out because of it.
It could also indicate 10 bit input file-hell, which is a rabbit hole of its own (which we could handle with scale_cuda=format=nv12 on some versions of ffmpeg, or simply fall back on no accelerated decode)