Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker labels to have update tools be able to pull changelog/release notes #4923

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

halkeye
Copy link

@halkeye halkeye commented Jun 4, 2024

For example https://docs.renovatebot.com/modules/datasource/docker/

but other tools will pull those same labels

@halkeye
Copy link
Author

halkeye commented Jun 4, 2024

Apparently it pulls the difference between "latest" and the latest tag? not 100% sure

$ regctl image config --format '{{ jsonPretty .Config.Labels }}' stashapp/stash
null

@WithoutPants
Copy link
Collaborator

I believe this is incomplete. The build dockerfiles are only used when building manually. The ci dockerfile is used by GitHub actions to deploy to docker hub. The build github actions file will also need to be updated to set the appropriate environment variable.

@halkeye
Copy link
Author

halkeye commented Aug 27, 2024

oh wow I can't believe i missed the build in https://github.com/stashapp/stash/blob/develop/docker/ci/x86_64/docker_push.sh
I'll get that second dockerfile updated

@halkeye
Copy link
Author

halkeye commented Sep 1, 2024

is there any easy way for me to confirm this ahead of time? I kinda did it blind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants