Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker tag filter #4844

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

itsame-luigi
Copy link

@itsame-luigi itsame-luigi commented May 15, 2024

This adds scene filters to filter either by markers having a specific primary tag, or by markers having any tag (primary or secondary).

Fixes #4772
Fixes #4350

@itsame-luigi
Copy link
Author

itsame-luigi commented May 16, 2024

Some additional or alternative approaches this could take:

  • Combine the "Primary Marker Tag" and "Marker Tags" criteria by introducing a specialized HierarchicalMultiCriterionInput that allows you to specify whether to only consider primary tags or all marker tags.
  • Don't distinguish between primary and secondary tags, i.e., remove the "Primary Marker Tag" criteria leaving only the "Marker Tags" criteria
  • Remove the "Has Markers" criteria and silently migrate saved queries to use the "Marker Tags" criteria with an IS_NULL or NOT_NULL modifier.

@WithoutPants
Copy link
Collaborator

I'm planning on introducing a markers_filter (of type SceneMarkerFilterType) field to SceneFilterType which will filter scenes based on having markers that meet criteria in markers_filter. This will allow filtering on marker tags and other marker attributes without having to introduce specific marker fields to SceneFilterType.

@stg-annon
Copy link
Collaborator

I'm planning on introducing a markers_filter (of type SceneMarkerFilterType) field to SceneFilterType which will filter scenes based on having markers that meet criteria in markers_filter.

any chance this will be coming to other object types in the future as well like performers?

@WithoutPants
Copy link
Collaborator

any chance this will be coming to other object types in the future as well like performers?

I should have been more specific yes. I'm planning on introducing these filter types across all filter types to eliminate the need for specific related object filtering fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants