Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play monitoring improvement #4670

Merged

Conversation

cj12312021
Copy link
Collaborator

This pull request updates the play monitoring code to detect video buffering and not count that towards the total play duration.

@cj12312021 cj12312021 added the improvement Something needed tweaking. label Mar 7, 2024
@cj12312021
Copy link
Collaborator Author

My latest push ensures that Track Activity is enabled by default.

@AdultSun
Copy link
Contributor

AdultSun commented Mar 7, 2024

Any chance this PR could also add tracking activity through DLNA? I don't know how difficult that would be.

#3681

@cj12312021
Copy link
Collaborator Author

DLNA doesn't use the front-end VideoJS player, so tracking activity there would likely not be done with the typescript code. So, the code would be completely separate from what we currently have. I have had it in mind to look into support on that side. I just need to spend some time understanding how playback works when using the DLNA service.

@AdultSun
Copy link
Contributor

AdultSun commented Mar 7, 2024

Thanks, I don't mean to pressure you if it's outside of the scope of your PR so no worries if you don't get to it. I just wanted to bring it up in case it was an easy add while you're working in this area.

@cj12312021
Copy link
Collaborator Author

No worries. I'm also interested in DLNA support, so you better believe I'd have a pull request out for the DLNA watch activity tracking once I've sorted out the details.

@WithoutPants
Copy link
Collaborator

My latest push ensures that Track Activity is enabled by default.

If this changes existing systems, this will require an accompanying release note.

@cj12312021
Copy link
Collaborator Author

cj12312021 commented Mar 8, 2024

The update should only affect new Stash configs. But I'll pull that change into a separate PR to avoid complicating the delivery of the play monitoring improvement.

@WithoutPants WithoutPants merged commit 3521dc1 into stashapp:develop Mar 12, 2024
2 checks passed
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants