-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
play monitoring improvement #4670
play monitoring improvement #4670
Conversation
My latest push ensures that Track Activity is enabled by default. |
Any chance this PR could also add tracking activity through DLNA? I don't know how difficult that would be. |
DLNA doesn't use the front-end VideoJS player, so tracking activity there would likely not be done with the typescript code. So, the code would be completely separate from what we currently have. I have had it in mind to look into support on that side. I just need to spend some time understanding how playback works when using the DLNA service. |
Thanks, I don't mean to pressure you if it's outside of the scope of your PR so no worries if you don't get to it. I just wanted to bring it up in case it was an easy add while you're working in this area. |
No worries. I'm also interested in DLNA support, so you better believe I'd have a pull request out for the DLNA watch activity tracking once I've sorted out the details. |
If this changes existing systems, this will require an accompanying release note. |
The update should only affect new Stash configs. But I'll pull that change into a separate PR to avoid complicating the delivery of the play monitoring improvement. |
This pull request updates the play monitoring code to detect video buffering and not count that towards the total play duration.