Toast improvements #4584
Merged
Toast improvements #4584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
* Change default toast placement * Position at bottom on mobile * Show single toast message at a time * Optionally show dialog for error messages * Fix circular dependency * Animate toast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1323
Changes the toast placement from center top to top right:
The toast container is now animated to slide in and out from the right edge of the window.
On mobile viewports the toast is placed center bottom, and slides in from the left:
The error toast is changed to add a button and handle clicks to bring up a dialog. On https connections, the dialog gives the option to copy the error message to clipboard: