Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix identify nil dereference #4171

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix identify nil dereference #4171

merged 1 commit into from
Oct 6, 2023

Conversation

DingDongSoLong4
Copy link
Collaborator

This is a straightforward fix for a nil deference panic when identifying scenes, that came up in Discord.

If the options input to the metadataIdentify graphql mutation is not specified, then t.DefaultOptions is nil, which causes the panic in getOptions.

@WithoutPants WithoutPants added the bug Something isn't working label Oct 6, 2023
@WithoutPants WithoutPants added this to the Version 0.23.0 milestone Oct 6, 2023
@WithoutPants WithoutPants merged commit 65fa81b into stashapp:develop Oct 6, 2023
2 checks passed
@DingDongSoLong4 DingDongSoLong4 deleted the fix-identify-panic branch October 6, 2023 11:27
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
@DingDongSoLong4 @halkeye
Fix identify nil dereference (stashapp#4171)
8b67e77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DingDongSoLong4 @WithoutPants