Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware): set baseURL to external host if provided #369

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

twotobinary
Copy link
Contributor

Added a fix for issue with reverse proxy: #368

To test this, I added external_host: https://my.domain.com to the config yml and created a docker image. Paths no longer contain the internal address that is inaccessible by the client.

@WithoutPants
Copy link
Collaborator

Code looks fine.

@bnkai
Copy link
Collaborator

bnkai commented Feb 13, 2020

Looks ok to me also.
@twotobinary did you test also the ENV part ? Instead of changing the config, just add the appropriate STASH_EXTERNAL_HOST env to the compose file for your docker test (should be ok though)

@twotobinary
Copy link
Contributor Author

@bnkai I just finished testing by adding env variable: STASH_EXTERNAL_HOST (and removed from config) and it works as expected. I also did a quick test without the variable to make sure original behavior was restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants