-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Studio Tagger #3510
Studio Tagger #3510
Changes from 18 commits
c7266b9
e8ab7da
0cdd331
784656c
2c8eeca
49e4621
599415c
ce735e0
6b783fa
feddb19
22c880a
d11bd6e
476f5f6
fa51ae8
da99a6c
65d1790
60db199
20eb282
5b79ae5
43279c5
a2884cf
cfc0144
20b66c2
a49b44e
801e076
a5d4511
bc50822
44ac1e1
fdc92f8
7881b2c
cf68d39
daf4dcf
7f2b84e
ef5f667
8c33574
c367c13
2a8bee4
d224c34
4c84a93
741ce2f
86b4031
b10c8e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ input StudioCreateInput { | |
name: String! | ||
url: String | ||
parent_id: ID | ||
parent: StudioCreateInput | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looking at the way this is processed in the resolver logic, I don't think it's a good design to include this. The behaviour isn't clear from the outside and the behaviour is based on whether an existing studio exists or not. The client should be responsible for creating/updating the parent studio. The only benefit I see in combining these operations is that you end up with a single transaction to roll back if needed, but I don't think it's worth it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've moved all parent studio logic out of the I think this comment means you're suggesting to also write this parent logic in the frontend, so that the frontend can make an api call to create/update a parent studio, then attach it to the main studio and make another api call to create/update studio? |
||
"""This should be a URL or a base64 encoded data URL""" | ||
image: String | ||
stash_ids: [StashIDInput!] | ||
|
@@ -46,6 +47,7 @@ input StudioUpdateInput { | |
name: String | ||
url: String | ||
parent_id: ID, | ||
parent: StudioCreateInput | ||
"""This should be a URL or a base64 encoded data URL""" | ||
image: String | ||
stash_ids: [StashIDInput!] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows for passing in a search query that can be a name or a stash id, and parse the text to find out which one.
It's the same library used on Stashbox.