Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI - Performer scraper result list with image and basic data #2697

Conversation

TgSeed
Copy link
Contributor

@TgSeed TgSeed commented Jun 25, 2022

As the title says, but also added toast and error messages.

closes #2695

@TgSeed TgSeed changed the title feat: UI - Performer scraper result list with Image and basic data feat: UI - Performer scraper result list with image and basic data Jun 25, 2022
@TgSeed
Copy link
Contributor Author

TgSeed commented Jun 25, 2022

Stashbox functionality for this part (Performer scraper) might have got disabled/non-functional.
I have no idea how that works and don't have stash box access to test and try to make it functional.

Can anyone please contribute or help with this? Thanks.

fix: Images works in YAML scrapers too (cast string to []string)
fix: uses postScrape in ScrapeName (Scrape with name/query)
@TgSeed
Copy link
Contributor Author

TgSeed commented Jun 26, 2022

There are also some minor contributions to #571 in this pull request.

@TgSeed TgSeed force-pushed the feat/ui/performer_scraper_result_list_with_image branch 2 times, most recently from 94f9cf8 to 80c448a Compare June 27, 2022 06:56
@TgSeed TgSeed force-pushed the feat/ui/performer_scraper_result_list_with_image branch from 80c448a to 25bcea3 Compare June 27, 2022 07:03
Results way faster search result if they include images needed to convert url to base64
@TgSeed
Copy link
Contributor Author

TgSeed commented Jun 27, 2022

post-scraping items in cache.ScrapeName is not done for scenes, and it might need to be done there too or neither.

It solves my issue where I use stash on my phone via my computer local network IP, but my phone has no internet access/cannot access the images' origin url while my computer can and is connected to the internet.
Post scraping converts the images' origin url to base64, so the image will be displayed on my phone too, even without internet access.

It may also solve some security concerns about connecting to the image's origin url.

@TgSeed
Copy link
Contributor Author

TgSeed commented Sep 25, 2022

80d138a has resolved the merge conflicts that has been recently occurred.

@TgSeed TgSeed force-pushed the feat/ui/performer_scraper_result_list_with_image branch from c77113c to 7a1dc83 Compare September 25, 2022 22:21
@ghost
Copy link

ghost commented Oct 22, 2022

If this works, big up to you, this feature is much needed !

@StashPRs
Copy link
Contributor

StashPRs commented Mar 1, 2023

Hey, don't wanna step on any toes, but since I can't collaborate on this PR directly, I made a variant (that keeps ownership for @TgSeed) but updates for the breaking changes in the codebase. If you want to pick the changes back, I can close mine. #3499

@DogmaDragon DogmaDragon added improvement Something needed tweaking. ui Issues related to UI labels Mar 1, 2023
@WithoutPants
Copy link
Collaborator

Closing in favour of #3499, please see my comments there.

@TgSeed
Copy link
Contributor Author

TgSeed commented Mar 9, 2023

@StashPRs I am glad that you did it, hope that gets merged anyway.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking. ui Issues related to UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Performer scraper result list with image and more
4 participants