Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vtt sprite generation ( issue #1033 ) #1035

Merged
merged 7 commits into from
Jan 14, 2021

Conversation

bnkai
Copy link
Collaborator

@bnkai bnkai commented Dec 31, 2020

Fixes #1033

@WithoutPants WithoutPants added the bug Something isn't working label Jan 3, 2021
@WithoutPants WithoutPants added this to the Version 0.5.0 milestone Jan 3, 2021
@WithoutPants
Copy link
Collaborator

WithoutPants commented Jan 6, 2021

This doesn't appear to work on Windows. I've set the generated directory to be tmp\[generated}. The escaped glob pattern looks like: tmp\\[generated\}\tmp\thumbnail_b7f0f0ee07f9f6d3_*.jpg, and the glob finds no files, despite the sprite files being present in that directory.

@bnkai
Copy link
Collaborator Author

bnkai commented Jan 6, 2021

@WithoutPants thanks for the feedback, i thought glob would first replace the escaped parts and then continue on windows but it seems that it just doesn't escape in windows

Note that for systems where the path separator is '\\', escaping is
disabled

I'll proceed with replacing doublestar glob with a custom function

@WithoutPants WithoutPants merged commit defb23a into stashapp:develop Jan 14, 2021
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Unable to Generate Sprites If Stash App Folders Are Located in a Folder with Square Brackets
2 participants