-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery wall view, and new lightbox #1008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Suggest making the arrow buttons in the lightbox a little more subdued. If you can't manipulate the color directly, I'd suggest just lowering the opacity at least.
{images.map((image) => ( | ||
<div className={CLASSNAME_IMAGE}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a key
prop set to stop the react warnings.
Finding a decent lightbox library is surprisingly hard, so I ended up writing one instead. Also added a wall view for galleries with a less jittery wall layout than flexbin.
The lightbox supports has more or less the same feature set as the previous library we used, and also supports pagination for image lists. The logic around that is kinda hairy, but it's working quite well.
Resolves #925