Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery wall view, and new lightbox #1008

Merged
merged 13 commits into from
Dec 24, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2020

Finding a decent lightbox library is surprisingly hard, so I ended up writing one instead. Also added a wall view for galleries with a less jittery wall layout than flexbin.

The lightbox supports has more or less the same feature set as the previous library we used, and also supports pagination for image lists. The logic around that is kinda hairy, but it's working quite well.

Resolves #925

@ghost ghost added the improvement Something needed tweaking. label Dec 20, 2020
@WithoutPants WithoutPants added this to the Version 0.5.0 milestone Dec 21, 2020
Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Suggest making the arrow buttons in the lightbox a little more subdued. If you can't manipulate the color directly, I'd suggest just lowering the opacity at least.

Comment on lines 297 to 298
{images.map((image) => (
<div className={CLASSNAME_IMAGE}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a key prop set to stop the react warnings.

@WithoutPants WithoutPants merged commit 232a69c into stashapp:develop Dec 24, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Carousel Rotation
1 participant