Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Disable "onwheel" parameter for performer page input forms using numerical values #5197

Closed
echo6ix opened this issue Sep 2, 2024 · 1 comment · Fixed by #5199
Labels
bug report Bug reports that are not yet verified

Comments

@echo6ix
Copy link
Contributor

echo6ix commented Sep 2, 2024

As discussed on Discord: Numerical input forms on the performer page can unintentionally get incremented or decremented when using a mouse wheel to scroll the pointer out of the input form. Unless a user specifically reviews the values they submitted after they save, any change in value from the scrolling will likely be unnoticed.

I was able to disable the behavior by adding onwheel="return false;" to the relevant input tags, though there may be a better approach

@echo6ix echo6ix added the bug report Bug reports that are not yet verified label Sep 2, 2024
@github-project-automation github-project-automation bot moved this to To triage in Bug fixing Sep 2, 2024
Gykes added a commit to Gykes/stash that referenced this issue Sep 2, 2024
So, a weird one because I don't think think this is a bug but it's a valid thing to change due potential of data being wrong.

Adding it into TextArea as well just to keep it uniform, can remove if you don't think it's needed

fixes stashapp#5197
@WithoutPants
Copy link
Collaborator

After further investigation and discussion, I have come to the conclusion that some of the behaviour here is buggy, and this seems to be limited to Chrome-based browsers.

Scrolling to change the values in numeric input fields is (as far as I can determine) a well-established feature of browser form behaviour for numeric input fields. The expected behaviour however is that when scrolling the mouse wheel while a numeric field is focused and hovered, it should mutate the field value and not scroll the viewport. What I am seeing on Chrome however is that it's doing both. This presents a usability issue since, as echo6ix discovered, it's not obvious to the user that the value has been changed. On other browsers, the window is not scrolled.

TLDR: using the mouse wheel to change numeric input values is expected when the field is focused and hovered, but it should not also be scrolling the window at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: Done
2 participants