Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit fields director and (studio) code to scene drafts #544

Merged
2 commits merged into from
Oct 31, 2022

Conversation

HappyAxolotl
Copy link
Contributor

In a PR for stash I've added the fields director and code to their Scene data model as these already exist in stash-box (stashapp/stash#3051). Now I want to include these fields when submitting a scene draft from stash to stash-box. Adding the fields to the SceneDraft and SceneDraftInput data structures worked well and the fields get added to the scene draft in the database.

However these fields aren't populated when opening the scene draft in the webbrowser, although they exist in the database (see screenshot). Unfortunately I couldn't find the frontend code that handles this. Can someone help me to find the frontend code that needs to be adjusted (I'm an absolute react newbie 😅)?
image

@peolic
Copy link
Contributor

peolic commented Oct 26, 2022

However these fields aren't populated when opening the scene draft in the webbrowser

Likely

director: null,
code: null,

@HappyAxolotl
Copy link
Contributor Author

Thank you! The submission now works correctly

@Foucoubou
Copy link

If I have seen correctly same issue is on performer page with start year and end year

@ghost ghost merged commit d719086 into stashapp:master Oct 31, 2022
@HappyAxolotl HappyAxolotl deleted the scene-draft-add-fields branch October 31, 2022 22:15
@HappyAxolotl
Copy link
Contributor Author

@Foucoubou Yea that's true, I might look into this after the performer refactor in stash is completed (see for example stashapp/stash#3057, stashapp/stash#3060)

Maista6969 pushed a commit to Maista6969/stash-box that referenced this pull request Jun 24, 2023
feederbox826 pushed a commit to feederbox826/stash-box that referenced this pull request Nov 15, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants