Merged
Conversation
Currently, builds are failing because of Rubocop complaining about these three lines.
mamhoff
changed the title
mamhoff
force-pushed
the
correct-rubocop-performance-offenses
branch
2 times, most recently
from
a109bd9 to
0e7fd51
Compare
Owner
|
Ty ty @mamhoff Happy to merge this one and leave the tests fixing for another task. Lmk wdyt? |
Contributor
Author
|
Sure, I tried fixing the specs with Ransack 4, but that's a whole different beast. |
Array#filter_map is only introduced in Ruby 2.7. This ensures we're still supporting the 2.x series, but drops support for the now pretty old Ruby 2.6.
Contributor
Author
|
So... The other option would be to ignore the cop. Your call :) |
Owner
|
Thank you @mamhoff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently, builds are failing because of Rubocop complaining about three lines.
What is the new behavior?
The build still fails because of Ransack 4 being incompatible with the library, but that's for a different PR.
Checklist
Please make sure the following requirements are complete:
Tests for the changes have been added (for bug fixes / features)Docs have been reviewed and added / updated if needed (for bug fixes /features)