always call jsonapi_page_size method on pagination enabled requests

[fluxsaas]

What is the current behavior?

related to issue #37

if you set the params page[size] in the query, jsonapi_page_size is not called and page[size] is used to determine the page size of the paginated response.

What is the new behavior?

always call the module method jsonapi_page_size and pass the value of the query param page[size] to the method to define the page size of the paginated response. Fallback to JSONAPI_PAGE_SIZE if page[size] is lower than 1 or not present in the query string at all.

Checklist

Please make sure the following requirements are complete:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes /
  features)
• All automated checks pass (CI/CD)

[fluxsaas]

@stas let me know if the implementation works for you, so i can add some docs and tests

[stas]

@fluxsaas this looks good. Two suggestions:

• let's handle the string-to-int conversion as part of the jsonapi_page_size method and remove the to_f.to_i from where it is called
• add a proper if/else block, or even better an early return instead of the ternary operator

Thank youuuu!!! 🙇

[fluxsaas]

@stas great, i think it makes sense to pass in the pagination hash, maybe the extra infos will help.

We would also avoid passing a string OR nil value to the method.

def jsonapi_page_size(pagination_params)
  per_page = pagination_params[:size].to_f.to_i

  return self.class
          .const_get(:JSONAPI_PAGE_SIZE)
          .to_i if per_page < 1

  per_page
end

see files for the updated version

[stas]

@fluxsaas sounds good. Are we ready to merge this? 🙃

[fluxsaas]

looks good from my side, i improved the Readme to reflect the changes.

[stas]

Sweet! I'll prepare the release in a bit! Thank you @fluxsaas 🙇