Merged
Conversation
3 tasks
Owner
|
@FinnLawrence I deeply apologize for the delay with this one. I'll get the CI fixed and merge this asap to unlock also other contributions. Thank you! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently, the pagination doesn't return the total number of records, which can be required on the client-side to generate pagination metadata, e.g.
1-10 of 29 widgets.This is referenced in #21 and #23 already, and while I agree that the
totalname proposed in #21 is confusing (could be total of pages?), the proposed solution there effectively replicates the existing functionality in/lib/jsonapi/pagination.rb.What is the new behavior?
Added a
recordskey to the pagination, that is the total number of records being paginated.Hopefully, this name is less confusing, and succinctly describes itself.
Checklist
Please make sure the following requirements are complete:
features)