Fix: Fix bugs in daemon and web #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing bracket and fixed wrong bracket.
Was causing the below 500 errors
[Sat Sep 21 19:29:03.353020 2024] [php:error] [pid 85107] [client 82.69.85.141:63866] PHP Parse error: syntax error, unexpected token ";", expecting ")" in /var/www/..../pages/ingame/motd.php on line 76
[Sat Sep 21 19:31:17.155449 2024] [php:error] [pid 85110] [client 82.69.85.141:63872] PHP Parse error: Unclosed '{' on line 80 does not match ']' in /var/www/..../pages/ingame/motd.php on line 82
…lled statically error
|
Hey @DNA-styx, thanks for the PR and commits. I've just taken a short refresher of this repo. It needs a few fixes since the last commit which has been some time ago, before merging this PR. A little question - would you want all the commits on this PR to be merged (i.e. is your master branch in working state)? If it's in working condition, we could just merge them all in. Thanks 😄 |
|
Just looked through the PR. These are excellent fixes. Thanks much! 😄 I will merge this for the next bugfix release. |
leojonathanoh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing bracket and fixed wrong bracket.
Was causing the below 500 errors
[Sat Sep 21 19:29:03.353020 2024] [php:error] [pid 85107] [client 82.69.85.141:63866] PHP Parse error: syntax error, unexpected token ";", expecting ")" in /var/www/..../pages/ingame/motd.php on line 76
[Sat Sep 21 19:31:17.155449 2024] [php:error] [pid 85110] [client 82.69.85.141:63872] PHP Parse error: Unclosed '{' on line 80 does not match ']' in /var/www/..../pages/ingame/motd.php on line 82