Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set time_from_start to feedback of joint trajectory action #1049

Closed

Conversation

pazeshun
Copy link
Collaborator

@pazeshun pazeshun commented Jul 9, 2018

For jsk-ros-pkg/jsk_pr2eus#233 (comment)
Complement #966

Note:
Feedback from HrpsysSeqStateROSBridge(fullbody_controller) always comes after first joint trajectory, so its time_from_start increases until next trajectory comes.
On the other hand, feedback from HrpsysJointTrajectoryBridge(rarm_controller etc.) stops when each trajectory is completely executed.

@pazeshun
Copy link
Collaborator Author

pazeshun commented Jul 9, 2018

@k-okada

Feedback from HrpsysSeqStateROSBridge(fullbody_controller) always comes after first joint trajectory

This behaviour is correct? If not, I want to fix this behaviour in this PR.

@pazeshun
Copy link
Collaborator Author

Feedback from HrpsysSeqStateROSBridge(fullbody_controller) always comes after first joint trajectory

This behaviour is correct? If not, I want to fix this behaviour in this PR.

I think this behaviour is bug, so I fixed this.

The reason of this behaviour is one publishFeedback is outside if block of follow_joint_trajectory_server.isActive() (https://github.com/start-jsk/rtmros_common/blob/1.4.2/hrpsys_ros_bridge/src/HrpsysSeqStateROSBridge.cpp#L578 ).
Other publishFeedbacks are inside that if block:
https://github.com/start-jsk/rtmros_common/blob/1.4.2/hrpsys_ros_bridge/src/HrpsysSeqStateROSBridge.cpp#L507-L510
https://github.com/start-jsk/rtmros_common/blob/1.4.2/hrpsys_ros_bridge/src/HrpsysSeqStateROSBridge.cpp#L512-L519
https://github.com/start-jsk/rtmros_common/blob/1.4.2/hrpsys_ros_bridge/src/HrpsysJointTrajectoryBridge.cpp#L350-L353
https://github.com/start-jsk/rtmros_common/blob/1.4.2/hrpsys_ros_bridge/src/HrpsysJointTrajectoryBridge.cpp#L356-L366

@pazeshun
Copy link
Collaborator Author

@Affonso-Gui Please use this.

@Affonso-Gui
Copy link
Member

@pazeshun Thanks. Looking forward to being merged.

@Affonso-Gui
Copy link
Member

@k-okada Can we merge this? It has been approved and passes the checks.

@pazeshun
Copy link
Collaborator Author

Moved to #1073

@pazeshun pazeshun closed this Nov 22, 2019
@pazeshun pazeshun reopened this Dec 12, 2019
@pazeshun pazeshun closed this Dec 12, 2019
@pazeshun pazeshun deleted the add-time-from-start-to-feedback branch December 12, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants