Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment explaining execution_resources name is for legacy #200

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

ShahakShama
Copy link
Collaborator

@ShahakShama ShahakShama commented Mar 10, 2024

This change is Reviewable

Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama)


api/starknet_trace_api_openrpc.json line 379 at r1 (raw file):

                            "execution_resources": {
                                "title": "Computation resources",
                                "description": "Resources consumed by the internal call. This is named execution_resources for legacy",

for legacy reasons

@ShahakShama ShahakShama force-pushed the shahak/execution_resources_legacy_description branch from 84416ee to d879e16 Compare March 11, 2024 06:53
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@ShahakShama ShahakShama merged commit eedf5f8 into master Mar 11, 2024
1 check passed
@ShahakShama ShahakShama deleted the shahak/execution_resources_legacy_description branch March 11, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants