Refactor traceTransactions and estimateFee, and rename STRK to FRI

[ArielElp]

This change is 

[yair-starkware]

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp)

---

api/starknet_api_openrpc.json line 3641 at r1 (raw file):

                "description": "Flags that indicate how to simulate a given transaction. By default, the sequencer behavior is replicated locally"
            },
            "FEE_ESTIMATE": {

Should fee estimates remain in gwei only?

Code quote:

"FEE_ESTIMATE"

[yair-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp)

---

api/starknet_api_openrpc.json line 3900 at r3 (raw file):

                            "description": "a string encoding the execution trace up to the point of failure",
                            "type": "string"
                        }

It should not be called revert_error anymore (if called from starknet_call for example)

Code quote:

                        "revert_error": {
                            "title": "revert error",
                            "description": "a string encoding the execution trace up to the point of failure",
                            "type": "string"
                        }

[ArielElp]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yair-starkware)

---

api/starknet_api_openrpc.json line 3641 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

Should fee estimates remain in gwei only?

They are gwei or fri, depending on the tx version (in practice, nodes will use the gas price published in blocks same as today, and will use price in wei/fri depending on the version). ATM I only changed the description, we can consider adding a unit field as we did for FEE_PAYMENT.

---

api/starknet_api_openrpc.json line 3900 at r3 (raw file):

Previously, yair-starkware (Yair) wrote…

It should not be called revert_error anymore (if called from starknet_call for example)

I think it's fine, IIUC this is the standard terminology in Ethereum (there is no tx to revert, but my "execution reverts).

[yair-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp)

[ArielElp]

Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @yair-starkware)

[ArielElp]

Reviewed 1 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

[kkovaacs]

This should be execution_error.