Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC 0.6 Fix declare txn v1 version #170

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

tabaktoni
Copy link
Contributor

@tabaktoni tabaktoni commented Nov 16, 2023

This looks like a mistake it should be "0x1" for v1 transaction.


This change is Reviewable

@tabaktoni
Copy link
Contributor Author

@ArielElp

@tabaktoni tabaktoni changed the title Fix/declare txn v1 version RPC 0.6 Fix declare txn v1 version Nov 21, 2023
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tabaktoni)

@ArielElp ArielElp merged commit 3a7ad5f into starkware-libs:master Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants