Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2847512320): adjust numeric types #20

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

danielgluskin-starkware
Copy link
Contributor

Description of the Changes

Some values may receive a numbers larger that JS number can hold, so we want to store it a string, yet have an informative way to tell the user that it should be Numeric only.

Solves #2847512320

Checklist

  • New unit / functional tests have been added (whenever applicable).
  • Docs have been updated (whenever relevant).
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

@danielgluskin-starkware danielgluskin-starkware marked this pull request as ready for review September 5, 2022 12:02
@danielgluskin-starkware danielgluskin-starkware deleted the feat/adjust-numeric-types branch September 5, 2022 13:12
dan-ziv pushed a commit that referenced this pull request Sep 5, 2022
 ## [0.1.0-dev.2](v0.1.0-dev.1...v0.1.0-dev.2) (2022-09-05)

### 🧩 Features

* **2847512320:** adjust numeric types ([#20](#20)) ([37550b7](37550b7))
@dan-ziv
Copy link
Collaborator

dan-ziv commented Sep 5, 2022

🎉 This PR is included in version 0.1.0-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request Sep 18, 2022
 ## [0.1.0](v0.0.6...v0.1.0) (2022-09-18)

### 🧩 Features

* **2847512314:** Add Stark Error Code ([#16](#16)) ([b276cda](b276cda))
* **2847512320:** adjust numeric types ([#20](#20)) ([37550b7](37550b7))
* **3075511177:** support multi-transaction ([#21](#21)) ([d788a18](d788a18))
* **3127780111:** drop support for availability gateway ([#25](#25)) ([bf8bbcf](bf8bbcf))
* **3127791831:** dynamic versioning ([#27](#27)) ([935dd55](935dd55))
* **3200394536:** gateway - add mark_transaction_for_replacement support ([#29](#29)) ([da402e7](da402e7))
* **3202221738:** feeder gateway - add v4.5 capabilities ([#26](#26)) ([a6b5975](a6b5975))

### 📚 Docs

* generate v4.5 canary docs ([#33](#33)) ([b8c2d71](b8c2d71))
@dan-ziv
Copy link
Collaborator

dan-ziv commented Sep 18, 2022

🎉 This PR is included in version 0.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants