apollo_infra: add component config validations

[nadin-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[nadin-Starkware]

• apollo_infra: add component config validations #8616 👈 (View in Graphite)
• apollo_infra: make local server and remote client optional #8610
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Merge activity

• Aug 18, 8:11 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 4 files reviewed, 4 unresolved discussions

---

crates/apollo_node/src/config/definitions.rs line 30 at r2 (raw file):

#[derive(Debug, Clone, Copy)]
pub enum Expected {

Too abstract imo. WDYT about ConfigExpectation?

Code quote:

Expected

---

crates/apollo_node/src/config/definitions.rs line 30 at r2 (raw file):

#[derive(Debug, Clone, Copy)]
pub enum Expected {

Needed?

Code quote:

pub

---

crates/apollo_node/src/config/definitions.rs line 32 at r2 (raw file):

pub enum Expected {
    Required,
    Forbidden,

Let's call this Redundant? Forbidden is too harsh imo.

Code quote:

Forbidden

---

crates/apollo_node/src/config/component_execution_config.rs line 289 at r2 (raw file):

fn to_presence<T>(opt: &Option<T>) -> Presence {
    if opt.is_some() { Presence::Present } else { Presence::Absent }
}

Please place near the definition of the enum.
Consider implementing Into or From traits (or their reference variant)

Code quote:

fn to_presence<T>(opt: &Option<T>) -> Presence {
    if opt.is_some() { Presence::Present } else { Presence::Absent }
}

[nadin-Starkware]

Reviewable status: 0 of 4 files reviewed, 4 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_node/src/config/component_execution_config.rs line 289 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please place near the definition of the enum.
Consider implementing Into or From traits (or their reference variant)

Done.

---

crates/apollo_node/src/config/definitions.rs line 30 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Too abstract imo. WDYT about ConfigExpectation?

Done.

---

crates/apollo_node/src/config/definitions.rs line 30 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Needed?

Done.

---

crates/apollo_node/src/config/definitions.rs line 32 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Let's call this Redundant? Forbidden is too harsh imo.

Done.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 4 files reviewed, 4 unresolved discussions (waiting on @nadin-Starkware)

---

crates/apollo_node/src/config/definitions.rs line 30 at r2 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Done.

I should have asked for that to be applied to the Presence enum as well, apologies for the implicitness.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 4 files reviewed, 4 unresolved discussions (waiting on @nadin-Starkware)

---

crates/apollo_node/src/config/definitions.rs line 32 at r3 (raw file):

pub(crate) enum ConfigExpectation {
    Required,
    Redundant,

alphabetize please (both)

Code quote:

    Required,
    Redundant,

[nadin-Starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_node/src/config/definitions.rs line 30 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

I should have asked for that to be applied to the Presence enum as well, apologies for the implicitness.

Done.

---

crates/apollo_node/src/config/definitions.rs line 32 at r3 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

alphabetize please (both)

Done.

[Itay-Tsabary-Starkware]

Reviewed 1 of 2 files at r1, 1 of 3 files at r2, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)