blockifier: get compiled class hash v2 state reader and contract manager #8432
Conversation
|
This change is |
|
Artifacts upload workflows: |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)
crates/blockifier/src/state/state_reader_and_contract_manager.rs line 105 at r1 (raw file):
fn get_compiled_class_hash_v2(&self, class_hash: ClassHash) -> StateResult<CompiledClassHash> { self.state_reader.get_compiled_class_hash_v2(class_hash)
Isn't it to call the contract_class_manager get_execution_class_v2 directly?
Code quote:
self.state_reader.get_compiled_class_hash_v2(class_hash)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1)
crates/blockifier/src/state/state_reader_and_contract_manager.rs line 105 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Isn't it to call the contract_class_manager get_execution_class_v2 directly?
Isn't it better*
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
crates/blockifier/src/state/state_reader_and_contract_manager.rs line 105 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Isn't it better*
I agree.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)
crates/blockifier/src/state/state_reader_and_contract_manager.rs line 105 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
I agree.
You are confused with the class_manager that Papyrus has.
This contractClassManager hasn't get_execution_class_v2
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @meship-starkware)
crates/blockifier/src/state/state_reader_and_contract_manager.rs line 105 at r1 (raw file):
Previously, AvivYossef-starkware wrote…
You are confused with the class_manager that Papyrus has.
This contractClassManager hasn'tget_execution_class_v2
But will have if we add a cache, no?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)
crates/blockifier/src/state/state_reader_and_contract_manager.rs line 105 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
But will have if we add a cache, no?
I'm working on it in different PRs, but we first should decide how to solve the issue I mentioned
No description provided.