blockifier: share sycall usage functions between native and vm #8375
+23
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Artifacts upload workflows: |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
einat-starkware
force-pushed
the
einat/08-03-blockifier_share_sycall_usage_functions_between_native_and_vm
branch
from
fa2e304 to
3ae1a24
Compare
noaov1
requested changes
Aug 4, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware)
crates/blockifier/src/execution/syscalls/hint_processor.rs line 476 at r1 (raw file):
fn increment_syscall_count_by(&mut self, selector: &SyscallSelector, count: usize) { self.base.increment_syscall_count_by(*selector, count); }
Is this method needed?
Code quote:
fn increment_syscall_count_by(&mut self, selector: &SyscallSelector, count: usize) {
self.base.increment_syscall_count_by(*selector, count);
}
noaov1
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)
crates/blockifier/src/execution/syscalls/hint_processor.rs line 476 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Is this method needed?
Needed for the SyscallExecutor trait.
einat-starkware
deleted the
einat/08-03-blockifier_share_sycall_usage_functions_between_native_and_vm
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.